MAYA-105368: set the edittarget to default into RootLayer instead of SessionLayer #661
Conversation
HamedSabri-adsk
added
workflows
There was a problem hiding this comment.
Works for me. There's probably a balance to be struck here between defaulting to the root layer as the edit target and explicitly switching to the session layer when authoring data that you intend to be transient, versus defaulting to the session layer as the edit target and explicitly switching to the root layer when authoring data that you intend to be permanent. We'll probably just have to see as things progress whether one or the other makes more sense, both for the behavior in user workflows but also for developers building out those workflows.
| # since currently UFE will author attribute values at default time which won't override | ||
| # attributes with time sampled data. Switching to session layer allows such manipulation | ||
| # to override time sampled data from root layer. | ||
| stage.SetEditTarget(stage.GetSessionLayer()) |
There was a problem hiding this comment.
@kxl-adsk thanks for the patch that you gave me earlier.
| self.assertEqual(stage.GetEditTarget().GetLayer(), stage.GetSessionLayer()) | ||
|
|
||
| # set the edit target to the root layer | ||
| stage.SetEditTarget(stage.GetRootLayer()) | ||
| self.assertEqual(stage.GetEditTarget().GetLayer(), stage.GetRootLayer()) |
There was a problem hiding this comment.
@kxl-adsk merged in dev into my branch and fixed the parenting test failures accordingly.
HamedSabri-adsk
added
the
ready-for-merge
No description provided.